⚡ zvariant, zbus: use borrowed clone if possible #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Signature::as_ref()
to get a borrowed clone of aSignature
. The code is a copy ofStr::as_ref()
.Even though cloning an
Arc
is cheap, it's not exactly for free. An atomic increment has some inherent overhead, andArc::clone()
alsopanic!()
s if there are excessively many strong references to anArc
. For everypanic!()
some code to unwind the stack has to be generated, which hurts cache locality, and bloats the generated code.